-
-
Notifications
You must be signed in to change notification settings - Fork 144
chore: bump upstream version #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
49f3269
chore: bump upstream version
yoyo837 9c87777
upgrade
yoyo837 aea83b1
test: part of test
zombieJ da6b6de
test: part of test
zombieJ d4be29b
test: part of test
zombieJ 30bf603
test: part of test
zombieJ 805b9bf
test: part of test
zombieJ 8573de4
test: part of test
zombieJ 1a4d9f4
test: part of test
zombieJ bee1293
test: part of test
zombieJ 72eee76
chore: fix lint
zombieJ f388b6c
chore: fix lint
zombieJ 7131691
chore: fix lint
zombieJ 7e8b366
chore: clean up
zombieJ 3be03df
test: update
zombieJ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| module.exports = { | ||
| setupFiles: ['./tests/setup.js'], | ||
| snapshotSerializers: [require.resolve('enzyme-to-json/serializer')], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping the
peerDependenciesforreactandreact-domto>=18.0.0is a significant breaking change. However, thedevDependenciesin this project are still using React 16 ("react": "^16.0.0","react-dom": "^16.0.0"). This means the project's tests are running against a version of React that no longer satisfies the new peer dependency requirement.To ensure compatibility, the library must be tested against the versions of React it claims to support. Please update the
devDependenciesto use React 18 and adjust the testing infrastructure accordingly. For example,enzyme-adapter-react-16is not compatible with React 18 and will need to be replaced or updated.