chore: remove @rc-component/textarea dependency#309
chore: remove @rc-component/textarea dependency#309zombieJ merged 1 commit intoreact-component:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 本次 PR 旨在进行一次内部依赖迁移，将 Mentions 组件对 TextArea 的实现从 @rc-component/textarea 切换到 @rc-component/input。此项调整不涉及 Mentions 组件的对外 API 变更，主要目的是优化内部依赖结构。 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
概览移除了 变化
可能相关的PR
预估代码审查工作量🎯 2 (Simple) | ⏱️ ~8 分钟 兔子的诗
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| import { BaseInput, TextArea } from '@rc-component/input'; | ||
| import type { HolderRef } from '@rc-component/input/lib/BaseInput'; | ||
| import type { CommonInputProps } from '@rc-component/input/lib/interface'; | ||
| import type { TextAreaProps, TextAreaRef } from '@rc-component/textarea'; | ||
| import TextArea from '@rc-component/textarea'; | ||
| import type { TextAreaProps, TextAreaRef } from '@rc-component/input'; |
There was a problem hiding this comment.
为了提高代码可读性并避免冗余的导入语句，可以将 TextAreaProps 和 TextAreaRef 的类型导入与 @rc-component/input 的值导入合并。
| import { BaseInput, TextArea } from '@rc-component/input'; | |
| import type { HolderRef } from '@rc-component/input/lib/BaseInput'; | |
| import type { CommonInputProps } from '@rc-component/input/lib/interface'; | |
| import type { TextAreaProps, TextAreaRef } from '@rc-component/textarea'; | |
| import TextArea from '@rc-component/textarea'; | |
| import type { TextAreaProps, TextAreaRef } from '@rc-component/input'; | |
| import { BaseInput, TextArea, type TextAreaProps, type TextAreaRef } from '@rc-component/input'; | |
| import type { HolderRef } from '@rc-component/input/lib/BaseInput'; | |
| import type { CommonInputProps } from '@rc-component/input/lib/interface'; |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #309 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 8 8
Lines 301 301
Branches 77 79 +2
=======================================
Hits 296 296
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
变更说明
本次调整移除了
@rc-component/textarea依赖，并将Mentions内部使用的TextArea、TextAreaProps、TextAreaRef全部切换为@rc-component/input提供的实现。这是一次内部依赖迁移，不涉及
Mentions对外 API 变更。具体改动
@rc-component/textarea依赖Mentions改为从@rc-component/input引入TextAreaMentions相关 textarea 类型改为使用@rc-component/input导出的类型Summary by CodeRabbit