🚨 fix inconsistent component state updates in example code #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React component state updates using setState may asynchronously update this.props and this.state, thus it is not safe to use either of the two when calculating the new state passed to setState, and instead the callback-based variant should be used instead.
|
Deploy preview for rc-menu failed. Built with commit e48ab83 https://app.netlify.com/sites/rc-menu/deploys/5c0f14100097d42028d347fc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that this is just in example code, but given that these are the only two alerts remaining for this project on LGTM, I thought it's probably worth the PR :)
React component state updates using
setStatemay asynchronously updatethis.propsandthis.state, thus it is not safe to use either of the two when calculating the new state passed tosetState, and instead the callback-based variant should be used instead. (details here).These were found on LGTM.com, and other than the alert fixed in #230, there are no remaining alerts.
(Full disclosure: I'm part of the team behind LGTM.com)