Skip to content

Conversation

@dispalt
Copy link
Contributor

@dispalt dispalt commented Jan 18, 2021

I manually verified this all works with story book. The tests pass, but I am sure it could be more elegant. Let me know if you have feedback. This is the follow up to #362

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #363 (088a662) into master (f9b55d6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   95.73%   95.76%   +0.02%     
==========================================
  Files          11       11              
  Lines         915      921       +6     
  Branches      270      271       +1     
==========================================
+ Hits          876      882       +6     
  Misses         39       39              
Impacted Files Coverage Δ
src/MenuItem.tsx 100.00% <ø> (ø)
src/DOMWrap.tsx 83.82% <100.00%> (+0.36%) ⬆️
src/SubMenu.tsx 98.29% <100.00%> (+0.01%) ⬆️
src/SubPopupMenu.tsx 96.42% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b55d6...088a662. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 18, 2021

This pull request introduces 2 alerts when merging 8b67c98 into f9b55d6 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@dispalt
Copy link
Contributor Author

dispalt commented Jan 18, 2021

This pull request introduces 2 alerts when merging 8b67c98 into f9b55d6 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

Fixed and force-pushed.

@afc163 afc163 requested a review from zombieJ January 19, 2021 01:46
@dispalt
Copy link
Contributor Author

dispalt commented Jan 21, 2021

Let me know if you'd like me to change something, @zombieJ . Thanks!

@dispalt
Copy link
Contributor Author

dispalt commented Feb 4, 2021

@zombieJ ping, if you could take a look, I'd be eternally grateful =)

@anuarml
Copy link

anuarml commented Feb 16, 2021

any update on when this will be merged? it would be great it this issue is closed ant-design/ant-design#26136 , thanks! @zombieJ

@dispalt
Copy link
Contributor Author

dispalt commented Feb 26, 2021

Hey folks, just a friendly ping, would love some feedback or a merge @afc163

@yoyo837
Copy link
Member

yoyo837 commented May 6, 2021

Please help to check rc-menu@9

@dispalt
Copy link
Contributor Author

dispalt commented May 6, 2021

Ill give it go!

@dispalt dispalt closed this May 6, 2021
@dispalt dispalt deleted the findDOMNode-2 branch May 6, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants