-
-
Notifications
You must be signed in to change notification settings - Fork 261
Replace SubMenu findDOMNode usage. #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
+ Coverage 95.73% 95.76% +0.02%
==========================================
Files 11 11
Lines 915 921 +6
Branches 270 271 +1
==========================================
+ Hits 876 882 +6
Misses 39 39
Continue to review full report at Codecov.
|
|
This pull request introduces 2 alerts when merging 8b67c98 into f9b55d6 - view on LGTM.com new alerts:
|
8b67c98 to
088a662
Compare
Fixed and force-pushed. |
|
Let me know if you'd like me to change something, @zombieJ . Thanks! |
|
@zombieJ ping, if you could take a look, I'd be eternally grateful =) |
|
any update on when this will be merged? it would be great it this issue is closed ant-design/ant-design#26136 , thanks! @zombieJ |
|
Hey folks, just a friendly ping, would love some feedback or a merge @afc163 |
|
Please help to check rc-menu@9 |
|
Ill give it go! |
I manually verified this all works with story book. The tests pass, but I am sure it could be more elegant. Let me know if you have feedback. This is the follow up to #362