performance: cache children to improve performance #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
reviewed
Dec 17, 2021
src/Menu.tsx
Outdated
Comment on lines
190
to
192
| const childList: React.ReactElement[] = React.useMemo(() => { | ||
| return parseChildren(children, EMPTY_LIST); | ||
| }, [children]); |
Member
There was a problem hiding this comment.
Suggested change
| const childList: React.ReactElement[] = React.useMemo(() => { | |
| return parseChildren(children, EMPTY_LIST); | |
| }, [children]); | |
| const childList: React.ReactElement[] = React.useMemo(() => parseChildren(children, EMPTY_LIST), [children]); |
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 25 25
Lines 674 675 +1
Branches 175 175
=======================================
+ Hits 673 674 +1
Misses 1 1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Member
|
@zombieJ 看看 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance via cache
relate: ant-design/ant-design#32681