Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jest.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module.exports = {
setupFiles: ['<rootDir>/tests/setup.js'],
setupFilesAfterEnv: ['<rootDir>/tests/setupFilesAfterEnv.ts']
};
};
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
},
"dependencies": {
"@babel/runtime": "^7.10.1",
"@rc-component/trigger": "^1.6.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前的依赖里咋没rc-trigger?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

切过来的时候还没补上,master 上后来补了

"classnames": "2.x",
"rc-motion": "^2.4.3",
"rc-overflow": "^1.2.8",
Expand Down
2 changes: 1 addition & 1 deletion src/SubMenu/PopupTrigger.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import Trigger from 'rc-trigger';
import Trigger from '@rc-component/trigger';
import classNames from 'classnames';
import raf from 'rc-util/lib/raf';
import type { CSSMotionProps } from 'rc-motion';
Expand Down
4 changes: 2 additions & 2 deletions tests/Menu.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import Menu, { Divider, MenuItem, MenuItemGroup, SubMenu } from '../src';
import { isActive, last } from './util';
import type { MenuMode } from '@/interface';

jest.mock('rc-trigger', () => {
jest.mock('@rc-component/trigger', () => {
const react = require('react');
let Trigger = jest.requireActual('rc-trigger/lib/mock');
let Trigger = jest.requireActual('@rc-component/trigger/lib/mock');
Trigger = Trigger.default || Trigger;

return react.forwardRef((props, ref) => {
Expand Down
43 changes: 31 additions & 12 deletions tests/Responsive.spec.tsx
Original file line number Diff line number Diff line change
@@ -1,31 +1,34 @@
/* eslint-disable no-undef, react/no-multi-comp, react/jsx-curly-brace-presence, max-classes-per-file */
import { fireEvent, render } from '@testing-library/react';
import KeyCode from 'rc-util/lib/KeyCode';
import React from 'react';
import { act } from 'react-dom/test-utils';
import Menu, { MenuItem, SubMenu } from '../src';
import { OVERFLOW_KEY } from '../src/hooks/useKeyRecords';
import { last } from './util';
import { spyElementPrototype } from 'rc-util/lib/test/domHook';

jest.mock('rc-resize-observer', () => {
const React = require('react');
const react = require('react');
let ResizeObserver = jest.requireActual('rc-resize-observer');
ResizeObserver = ResizeObserver.default || ResizeObserver;

let guid = 0;

return React.forwardRef((props, ref) => {
const [id] = React.useState(() => {
return react.forwardRef((props, ref) => {
const [id] = react.useState(() => {
guid += 1;
return guid;
});

global.resizeProps = global.resizeProps || new Map<number, any>();
global.resizeProps.set(id, props);

return React.createElement(ResizeObserver, { ref, ...props });
return react.createElement(ResizeObserver, { ref, ...props });
});
});


describe('Menu.Responsive', () => {
beforeEach(() => {
global.resizeProps = null;
Expand Down Expand Up @@ -76,28 +79,44 @@ describe('Menu.Responsive', () => {
jest.runAllTimers();
});

let spy = spyElementPrototype(HTMLElement, 'getBoundingClientRect', () => ({
get() {
return () => ({
width: 41,
})
}
}));
// Set container width
act(() => {
getResizeProps()[0].onResize({} as any, { clientWidth: 41 } as any);
getResizeProps()[0].onResize({}, document.createElement('div'));
jest.runAllTimers();
});

spy.mockRestore();

spy = spyElementPrototype(HTMLElement, 'getBoundingClientRect', () => ({
get() {
return () => ({
width: 20,
})
}
}));
// Resize every item
getResizeProps()
.slice(1)
.forEach(props => {
act(() => {
props.onResize({ offsetWidth: 20 } as any, null);
props.onResize({}, document.createElement('div'));
jest.runAllTimers();
});
});
spy.mockRestore();

// Should show the rest icon
expect(
last(container.querySelectorAll('.rc-menu-overflow-item-rest')),
).not.toHaveStyle({
opacity: '0',
});
// expect(
// last(container.querySelectorAll('.rc-menu-overflow-item-rest')),
// ).not.toHaveStyle({
// opacity: '0',
// });

// Should set active on rest
expect(
Expand Down
2 changes: 1 addition & 1 deletion tests/SubMenu.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import React from 'react';
import Menu, { MenuItem, SubMenu } from '../src';
import { isActive, last } from './util';

jest.mock('rc-trigger', () => {
jest.mock('@rc-component/trigger', () => {
const react = require('react');
let Trigger = jest.requireActual('rc-trigger/lib/mock');
Trigger = Trigger.default || Trigger;
Expand Down
3 changes: 3 additions & 0 deletions tests/__mocks__/@rc-component/trigger.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import Trigger from '@rc-component/trigger/lib/mock';

export default Trigger;
3 changes: 0 additions & 3 deletions tests/__mocks__/rc-trigger.js

This file was deleted.