Skip to content

[codex] refactor notification legacy structure#384

Draft
zombieJ wants to merge 76 commits intomasterfrom
refactor/legacy-structure
Draft

[codex] refactor notification legacy structure#384
zombieJ wants to merge 76 commits intomasterfrom
refactor/legacy-structure

Conversation

@zombieJ
Copy link
Copy Markdown
Member

@zombieJ zombieJ commented Apr 24, 2026

Summary

  • Move the notification implementation to the new Notification / NotificationList structure
  • Remove the unused src/legacy implementation after replacing the remaining context dependency
  • Keep tests aligned with the original coverage, adjusting only for description and DOM changes, plus a minimal custom progress component test

Validation

  • npm test
  • npm run lint
  • npm run compile

zombieJ and others added 30 commits March 11, 2026 22:53
- Remove unused props: children, icon, title
- Add duration, pauseOnHover, onClick props
- Simplify component structure

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add useNoticeTimer hook for auto-close timer with pause/resume support
- Add onClose callback prop for timeout-based closing
- Add pauseOnHover support (default: true) to pause timer on mouse hover
- Add onClick handler support
- Set default duration to 4.5 seconds

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… types

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 24, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: tschaub npm gh-pages vulnerable to prototype pollution

CVE: GHSA-8mmm-9v2q-x3f9 tschaub gh-pages vulnerable to prototype pollution (CRITICAL)

Affected versions: < 5.0.0

Patched version: 5.0.0

From: package.jsonnpm/gh-pages@3.2.3

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/gh-pages@3.2.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants