Skip to content

Conversation

@afc163
Copy link
Member

@afc163 afc163 commented May 22, 2020

pageSize 指定了不在默认 pageSizeOptions 里面的值时,原来会这样展示。

image

优化后,会把 pageSize 插入到现有的 pageSizeOptions 里,符合用户直觉,体验更好。

image

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #270 into master will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   90.70%   90.96%   +0.26%     
==========================================
  Files           3        3              
  Lines         312      321       +9     
  Branches      108      111       +3     
==========================================
+ Hits          283      292       +9     
  Misses         29       29              
Impacted Files Coverage Δ
src/Options.jsx 93.44% <100.00%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da77861...950ba03. Read the comment docs.

@afc163 afc163 merged commit a262ee7 into master May 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the improve-PageSizeOptions branch May 22, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants