🐛 fix gradient for circle progress does not have unique id

[wzhudev]

@afc163 I think we should release a new version? I should update the main package as well.

fix ant-design/ant-design#18113

Quick preview:

[wzhudev]

@zombieJ Please read this issue ant-design/ant-design#18113 (comment). How to treat progress which has successPercent? Should the path for success percent be gradient of just green?

[zombieJ]

Current is green. But I think this can be discuss.

[wzhudev]

Current is green. But I think this can be discuss.

In my opinion we should keep it green.

Due to how the gradient is implemented now, all paths would have the same stroke color and paths on the top would be completely invisible.

[codecov]

Codecov Report

Merging #76 into master will increase coverage by 0.19%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   98.14%   98.34%   +0.19%     
==========================================
  Files           5        5              
  Lines         108      121      +13     
  Branches       24       24              
==========================================
+ Hits          106      119      +13     
  Misses          2        2

Impacted Files	Coverage Δ
src/types.js	100% <ø> (ø)	⬆️
src/Circle.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acdae83...9a34d82. Read the comment docs.

[wzhudev]

@zombieJ Ping.

[wzhudev]

I need some help with PropTypes.

PropTypes.arrayOf(PropTypes.any) // loose

// in TypeScript
export type Color = Array<string | Object>

How can I write an equivalent using PropTypes?

I tried:

 PropTypes.arrayOf(PropTypes.oneOf([PropTypes.string, PropTypes.object])),

but no luck.

[zombieJ]

PropTypes.arrayOf(
  PropTypes.oneOfType([
    PropTypes.string,
    PropTypes.object,
  ])
)

[wzhudev]

PropTypes.arrayOf(
  PropTypes.oneOfType([
    PropTypes.string,
    PropTypes. object,
  ])
)

Oh I see...

[zombieJ]

Hmmm...
Origin test case dose not test anything on gradient:
https://github.com/react-component/progress/blob/master/tests/index.spec.js#L82

Could you help to update this. Render with 2 gradient chart and check id should be different.

[wzhudev]

Ok. Will do.

[wzhudev]

As a matter of fact, all tests only have an expectation:

expect(circle.state.percent).toBe('30');

[zombieJ]

Yes. That's not cool.

[wzhudev]

I only added tests about gradient. Maybe we could enhance tests in another pr.