Skip to content

perf: uninstall classnames, install clsx #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2025
Merged

perf: uninstall classnames, install clsx #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,18 @@
},
"dependencies": {
"@babel/runtime": "^7.11.1",
"classnames": "^2.2.1",
"rc-motion": "^2.4.4",
"@rc-component/util": "^1.3.0"
"@rc-component/util": "^1.3.0",
"clsx": "^2.1.1",
"rc-motion": "^2.4.4"
},
"devDependencies": {
"@rc-component/father-plugin": "^2.0.1",
"@rc-component/np": "^1.0.0",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^14.2.1",
"@testing-library/user-event": "^14.5.2",
"@types/classnames": "^2.2.9",
"@types/jest": "^29.2.4",
"@types/node": "^24.5.2",
"@types/react": "^18.3.11",
"@types/react-dom": "^18.3.1",
"@umijs/fabric": "^3.0.0",
Expand Down
4 changes: 2 additions & 2 deletions src/MotionThumb.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import useLayoutEffect from '@rc-component/util/lib/hooks/useLayoutEffect';
import { composeRef } from '@rc-component/util/lib/ref';
import classNames from 'classnames';
import { clsx } from 'clsx';
import CSSMotion from 'rc-motion';
import * as React from 'react';
import type { SegmentedValue } from '.';
Expand Down Expand Up @@ -211,7 +211,7 @@ export default function MotionThumb(props: MotionThumbInterface) {
const motionProps = {
ref: composeRef(thumbRef, ref),
style: mergedStyle,
className: classNames(`${prefixCls}-thumb`, motionClassName),
className: clsx(`${prefixCls}-thumb`, motionClassName),
};

if (process.env.NODE_ENV === 'test') {
Expand Down
16 changes: 6 additions & 10 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import useControlledState from '@rc-component/util/lib/hooks/useControlledState';
import omit from '@rc-component/util/lib/omit';
import { composeRef } from '@rc-component/util/lib/ref';
import classNames from 'classnames';
import { clsx } from 'clsx';
import * as React from 'react';

import MotionThumb from './MotionThumb';
Expand Down Expand Up @@ -132,9 +132,7 @@ const InternalSegmentedOption: React.FC<{
};
const itemContent: React.ReactNode = (
<label
className={classNames(className, {
[`${prefixCls}-item-disabled`]: disabled,
})}
className={clsx(className, { [`${prefixCls}-item-disabled`]: disabled })}
style={style}
onMouseDown={onMouseDown}
>
Expand All @@ -151,10 +149,7 @@ const InternalSegmentedOption: React.FC<{
onKeyUp={onKeyUp}
/>
<div
className={classNames(
`${prefixCls}-item-label`,
segmentedClassNames?.label,
)}
className={clsx(`${prefixCls}-item-label`, segmentedClassNames?.label)}
title={title}
role="radio"
aria-checked={checked}
Expand Down Expand Up @@ -189,6 +184,7 @@ const Segmented = React.forwardRef<HTMLDivElement, SegmentedProps>(
} = props;

const containerRef = React.useRef<HTMLDivElement>(null);

const mergedRef = React.useMemo(
() => composeRef<HTMLDivElement>(containerRef, ref),
[containerRef, ref],
Expand Down Expand Up @@ -281,7 +277,7 @@ const Segmented = React.forwardRef<HTMLDivElement, SegmentedProps>(
itemRender={itemRender}
key={optionValue}
prefixCls={prefixCls}
className={classNames(
className={clsx(
segmentedOption.className,
`${prefixCls}-item`,
segmentedClassNames?.item,
Expand Down Expand Up @@ -314,7 +310,7 @@ const Segmented = React.forwardRef<HTMLDivElement, SegmentedProps>(
tabIndex={disabled ? undefined : 0}
style={style}
{...divProps}
className={classNames(
className={clsx(
prefixCls,
{
[`${prefixCls}-rtl`]: direction === 'rtl',
Expand Down