chore: update maintenance dependencies #1235
+254
−60
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| import { FlatCompat } from '@eslint/eslintrc'; | ||
| import js from '@eslint/js'; | ||
| import tsEslintPlugin from '@typescript-eslint/eslint-plugin'; | ||
| import { createRequire } from 'node:module'; | ||
| import path from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = path.dirname(__filename); | ||
| const require = createRequire(import.meta.url); | ||
|
|
||
| const compat = new FlatCompat({ | ||
| baseDirectory: __dirname, | ||
| recommendedConfig: js.configs.recommended, | ||
| allConfig: js.configs.all, | ||
| }); | ||
|
|
||
| const recommendedTsRules = new Set(Object.keys(tsEslintPlugin.configs.recommended.rules || {})); | ||
| const noopRule = { | ||
| meta: { type: 'problem', docs: {}, schema: [] }, | ||
| create: () => ({}), | ||
| }; | ||
|
|
||
| function normalizeConfig(config) { | ||
| const next = { ...config }; | ||
|
|
||
| if (next.plugins?.['@typescript-eslint']) { | ||
| next.plugins = { ...next.plugins }; | ||
| delete next.plugins['@typescript-eslint']; | ||
| } | ||
|
|
||
| if (next.rules) { | ||
| next.rules = Object.fromEntries( | ||
| Object.entries(next.rules).filter(([ruleName]) => { | ||
| if (!ruleName.startsWith('@typescript-eslint/')) { | ||
| return true; | ||
| } | ||
| return recommendedTsRules.has(ruleName) || ruleName === '@typescript-eslint/ban-types'; | ||
| }), | ||
| ); | ||
| } | ||
|
|
||
| return next; | ||
| } | ||
|
|
||
| export default [ | ||
| { | ||
| ignores: [ | ||
| 'node_modules/', | ||
| 'coverage/', | ||
| 'es/', | ||
| 'lib/', | ||
| 'dist/', | ||
| 'docs-dist/', | ||
| '.dumi/', | ||
| '.doc/', | ||
| '.vercel/', | ||
| '.eslintrc.js', | ||
| 'src/index.d.ts', | ||
| ], | ||
| }, | ||
| { | ||
| plugins: { | ||
| '@typescript-eslint': { | ||
| ...tsEslintPlugin, | ||
| rules: { | ||
| ...tsEslintPlugin.rules, | ||
| 'ban-types': noopRule, | ||
| 'consistent-type-exports': noopRule, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ...compat.config(require('./.eslintrc.js')).map(normalizeConfig), | ||
| { | ||
| rules: { | ||
| '@typescript-eslint/ban-types': 'off', | ||
| '@typescript-eslint/no-empty-object-type': 'off', | ||
| '@typescript-eslint/no-unsafe-function-type': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| }, | ||
| }, | ||
| ]; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /// <reference types="jest" /> | ||
| /// <reference types="node" /> | ||
| /// <reference types="react" /> | ||
| /// <reference types="react-dom" /> | ||
| /// <reference types="@testing-library/jest-dom" /> | ||
|
|
||
| declare module '*.css'; | ||
| declare module '*.less'; | ||
| declare module 'jsonp'; | ||
|
|
||
| declare namespace JSX { | ||
| type Element = React.JSX.Element; | ||
| interface ElementClass extends React.JSX.ElementClass {} | ||
| interface ElementAttributesProperty extends React.JSX.ElementAttributesProperty {} | ||
| interface ElementChildrenAttribute extends React.JSX.ElementChildrenAttribute {} | ||
| type LibraryManagedAttributes<C, P> = React.JSX.LibraryManagedAttributes<C, P>; | ||
| interface IntrinsicAttributes extends React.JSX.IntrinsicAttributes {} | ||
| interface IntrinsicClassAttributes<T> extends React.JSX.IntrinsicClassAttributes<T> {} | ||
| interface IntrinsicElements extends React.JSX.IntrinsicElements {} | ||
| } | ||
|
|
||
| declare namespace jest { | ||
| interface Matchers<R> { | ||
| lastCalledWith(...expected: unknown[]): R; | ||
| nthCalledWith(nthCall: number, ...expected: unknown[]): R; | ||
| toBeCalled(): R; | ||
| toBeCalledTimes(expected: number): R; | ||
| toBeCalledWith(...expected: unknown[]): R; | ||
| } | ||
| } | ||
|
|
||
| declare const vi: { | ||
| fn: <T extends (...args: any[]) => any = (...args: any[]) => any>( | ||
| implementation?: T, | ||
| ) => jest.MockedFunction<T>; | ||
| mock: (moduleName: string, factory?: (importOriginal: <T>() => Promise<T>) => unknown) => void; | ||
| spyOn: typeof jest.spyOn; | ||
| useFakeTimers: () => void; | ||
| useRealTimers: () => void; | ||
| advanceTimersByTime: (msToRun: number) => void; | ||
| clearAllTimers: () => void; | ||
| runAllTimers: () => void; | ||
| importActual: <T>(moduleName: string) => Promise<T>; | ||
| clearAllMocks: () => void; | ||
| resetAllMocks: () => void; | ||
| restoreAllMocks: () => void; | ||
| }; | ||
|
|
||
| declare module 'moment/locale/zh-cn'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import * as React from 'react'; | ||
|
|
||
| declare module 'react' { | ||
| type ReactText = string | number; | ||
| function useRef<T = undefined>(): React.MutableRefObject<T | undefined>; | ||
| function isValidElement<P = any>(object: {} | null | undefined): object is React.ReactElement<P>; | ||
| function cloneElement<P = any>( | ||
| element: React.ReactElement<P>, | ||
| props?: (Partial<P> & React.Attributes) | null, | ||
| ...children: React.ReactNode[] | ||
| ): React.ReactElement<P>; | ||
| } | ||
|
Comment on lines
+3
to
+12
Contributor
There was a problem hiding this comment. Overriding standard React types globally via ambient module declaration ( Instead of global module augmentation, consider using local type assertions or utility types within the codebase where compatibility adjustments are needed. |
||
|
|
||
| declare module 'react-dom' { | ||
| function hydrate(element: React.ReactNode, container: Element | DocumentFragment): void; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,19 +116,19 @@ function warningProps(props: SelectProps) { | |
| return false; | ||
| } | ||
| if (type.isSelectOptGroup) { | ||
| const allChildrenValid = toNodeArray( | ||
| (node as React.ReactElement<any>).props.children, | ||
| ).every((subNode: React.ReactElement) => { | ||
| if ( | ||
| !React.isValidElement(subNode) || | ||
| !node.type || | ||
| (subNode.type as { isSelectOption?: boolean }).isSelectOption | ||
| ) { | ||
| return true; | ||
| } | ||
| invalidateChildType = subNode.type; | ||
| return false; | ||
| }); | ||
|
|
||
| if (allChildrenValid) { | ||
| return false; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,9 @@ | ||
| import { fireEvent } from '@testing-library/dom'; | ||
| import * as React from 'react'; | ||
| import { KeyCode } from '@rc-component/util'; | ||
| import Select from '../src'; | ||
| import { injectRunAllTimers, expectOpen, keyDown } from './utils/common'; | ||
| import { act, render } from '@testing-library/react'; | ||
|
|
||
| describe('Select.Accessibility', () => { | ||
| injectRunAllTimers(jest); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| import { fireEvent } from '@testing-library/dom'; | ||
| import type { OptionListProps, RefOptionListProps } from '../src/OptionList'; | ||
| import { render } from '@testing-library/react'; | ||
| import { forwardRef, act } from 'react'; | ||
| import BaseSelect from '../src/BaseSelect'; | ||
| import { waitFakeTimer } from './utils/common'; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| import { createEvent, fireEvent } from '@testing-library/dom'; | ||
| /* eslint-disable max-classes-per-file */ | ||
|
|
||
| import '@testing-library/jest-dom'; | ||
| import { render } from '@testing-library/react'; | ||
| import { KeyCode, resetWarned } from '@rc-component/util'; | ||
| import React, { act } from 'react'; | ||
| import type { SelectProps } from '../src'; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| import { fireEvent } from '@testing-library/dom'; | ||
| import * as React from 'react'; | ||
| import Select from '../src'; | ||
| import { injectRunAllTimers, waitFakeTimer } from './utils/common'; | ||
| import { render } from '@testing-library/react'; | ||
|
|
||
| describe('Select.Custom', () => { | ||
| injectRunAllTimers(jest); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,9 @@ | ||
| import { fireEvent } from '@testing-library/dom'; | ||
| import React, { act } from 'react'; | ||
| import Select from '../src'; | ||
| import type { SelectProps } from '../src'; | ||
| import { injectRunAllTimers } from './utils/common'; | ||
| import { render } from '@testing-library/react'; | ||
|
|
||
| describe('Select.Field', () => { | ||
| injectRunAllTimers(jest); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| import { fireEvent } from '@testing-library/dom'; | ||
| import * as React from 'react'; | ||
| import Select, { OptGroup, Option } from '../src'; | ||
| import { render } from '@testing-library/react'; | ||
|
|
||
| describe('Select.Group', () => { | ||
| it('group name support search', () => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import { fireEvent } from '@testing-library/dom'; | ||
| import { KeyCode } from '@rc-component/util'; | ||
| import React from 'react'; | ||
| import Select, { Option, OptGroup } from '../src'; | ||
|
|
@@ -19,7 +20,7 @@ import { | |
| keyUp, | ||
| } from './utils/common'; | ||
| import allowClearTest from './shared/allowClearTest'; | ||
| import { act, render, screen } from '@testing-library/react'; | ||
|
|
||
| describe('Select.Multiple', () => { | ||
| injectRunAllTimers(jest); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import { createEvent, fireEvent } from '@testing-library/dom'; | ||
| import { KeyCode, spyElementPrototypes } from '@rc-component/util'; | ||
| import React, { act } from 'react'; | ||
| import { BaseSelectContext } from '../src/hooks/useBaseProps'; | ||
|
|
@@ -6,7 +7,7 @@ import OptionList from '../src/OptionList'; | |
| import SelectContext from '../src/SelectContext'; | ||
| import { fillFieldNames, flattenOptions } from '../src/utils/valueUtil'; | ||
| import { injectRunAllTimers } from './utils/common'; | ||
| import { render, waitFor } from '@testing-library/react'; | ||
| import Select from '../src'; | ||
|
|
||
| jest.mock('../src/utils/platformUtil'); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| import { fireEvent } from '@testing-library/dom'; | ||
| import { render } from '@testing-library/react'; | ||
| import React from 'react'; | ||
| import Select from '../src'; | ||
| import { injectRunAllTimers } from './utils/common'; | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filtering logic silently discards any custom
@typescript-eslintrules configured in.eslintrc.jsthat are not part of the recommended set. This can lead to unexpected behavior where intended lint rules are silently disabled without warning.Instead of silently filtering rules in a helper function, consider explicitly disabling or overriding specific rules in the flat config array, or updating
.eslintrc.jsto remove deprecated rules.