fix handleStyle with createSliderWithTooltip#364
Closed
Orange-C wants to merge 1 commit intoreact-component:masterfrom
Closed
fix handleStyle with createSliderWithTooltip#364Orange-C wants to merge 1 commit intoreact-component:masterfrom
Orange-C wants to merge 1 commit intoreact-component:masterfrom
Conversation
Member
|
Could you add a test case, then I can merge it. |
Author
|
@yesmeck It's too late to merge this commit : ( , looks like someone in your team fixed the problem during these months , just close this. |
Member
|
@Orange-C Thanks for your contribution anyway. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
porps.handleStyle could be array or object now.
fix bug: handleStyle[0] work with all handles
by the way, how about supporting porps.handle when using createSliderWithTooltip?