Closed
Conversation
merge request
merge request
Fix ie8 event bug & update stylesheet
Fix ie8 event bug & update stylesheet
0aabf23 to
a49a3d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using rc-slider on a mobile web project, and was having trouble getting the slider to work in mobile Safari. This is a quick attempt to add in touch event handling by translating touch events to mouse events and calling the existing mouse event handlers. This gets it working on mobile, but is probably not the best way to handle this.
I'd be curious to hear if you plan to add touch support in the future, or if you think this is an ok way to go about aping the mouse events api.