Disable key behavior when component disabled #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add space and enter key support for toggling checked state Disable key behavior when component in disabled state
delesseps
changed the title
Contributor
Author
|
@afc163 Is this suitable for merge? Thanks! |
benjycui
reviewed
Jun 14, 2017
examples/simple.js
Outdated
| disabled: false, | ||
| }; | ||
| toggle = () => { | ||
| const Test = React.createClass({ |
Member
There was a problem hiding this comment.
Why??? We should not use React.createClass after React@15.5, just use ES6 class.
Contributor
Author
There was a problem hiding this comment.
Np, updating was just following conventions used in other components
Member
|
👍 |
afc163
reviewed
Jun 17, 2017
src/Switch.jsx
Outdated
| } | ||
| if (e.keyCode === 39) { | ||
| this.setChecked(true); | ||
| if (!this.props.disabled) { |
Member
There was a problem hiding this comment.
It is better to put disabled logic into setChecked.
Member
|
Thx @delesseps ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also...