Skip to content

Conversation

@ironosity
Copy link

Added new properties headerCellClassName and bodyCellClassName that are functions which allow a class name to be computed on each body cell or header cell individually. This follows the same pattern as rowClassName() and allows end user to have even greater control over the styling of the table when needed.

Eric Merrill added 2 commits January 20, 2017 13:09
…re functions which allow a class name to be computed on each body cell or header cell individually.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 86.452% when pulling 5afde22 on ironosity:master into c537534 on react-component:master.

@ironosity
Copy link
Author

If there's anything else I need to do here @yesmeck, just let me know. Thanks!

@yesmeck
Copy link
Member

yesmeck commented Jan 25, 2017

Hi @ironosity, sorry for delayed response, my concern is that Table has too many props. For headerCellClassName, you can use column[className], then query header cell by th.columnClassName. For bodyCellClassName, you can use column[className] with rowClassName, then query body cell by .rowClassName .columnClassName. So I don't think headerCellClassName() and bodyCellClassName() are necessary, less is more.

@ironosity
Copy link
Author

Ok, going to close it then. Thank!

@ironosity ironosity closed this Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants