Skip to content

Conversation

shaodahong
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Aug 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/table/259xxtsbs
✅ Preview: https://table-git-fix-26379.react-component.vercel.app

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #521 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files          25       25              
  Lines         764      762       -2     
  Branches      220      220              
==========================================
- Hits          763      761       -2     
  Misses          1        1              
Impacted Files Coverage Δ
src/stickyScrollBar.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f2c49...77efed4. Read the comment docs.

@shaodahong
Copy link
Member Author

这个 codecov/project 为啥会失败

@zombieJ
Copy link
Member

zombieJ commented Aug 25, 2020

onMouseUp 是不是也可以不用 preventDefault?

@zombieJ
Copy link
Member

zombieJ commented Aug 25, 2020

mockFn 可以改成每个调用地方都是一个新的 jest.fn,免得相互作用算不清数~

@zombieJ
Copy link
Member

zombieJ commented Aug 25, 2020

这个 codecov/project 为啥会失败

0.01 估计是总体行数少了,导致未 cover 比例上升了。

@shaodahong
Copy link
Member Author

mockFn 可以改成每个调用地方都是一个新的 jest.fn,免得相互作用算不清数~

嗯,mousemove 和 mouseup 的都去掉了,没用了

@zombieJ zombieJ merged commit 6d09d6b into master Aug 25, 2020
@zombieJ zombieJ deleted the fix-26379 branch August 25, 2020 08:56
@zombieJ
Copy link
Member

zombieJ commented Aug 25, 2020

+ rc-table@7.9.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants