Skip to content

chore: remove mergedTabPosition #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2022
Merged

chore: remove mergedTabPosition #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/Tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,6 @@ function Tabs(
value: id,
});

let mergedTabPosition = tabPosition;
if (mobile && !['left', 'right'].includes(tabPosition)) {
mergedTabPosition = 'top';
}

// Async generate id to avoid ssr mapping failed
useEffect(() => {
if (!id) {
Expand All @@ -166,7 +161,7 @@ function Tabs(
id: mergedId,
activeKey: mergedActiveKey,
animated: mergedAnimated,
tabPosition: mergedTabPosition,
tabPosition,
rtl,
mobile,
};
Expand Down Expand Up @@ -196,7 +191,7 @@ function Tabs(
id={id}
className={classNames(
prefixCls,
`${prefixCls}-${mergedTabPosition}`,
`${prefixCls}-${tabPosition}`,
{
[`${prefixCls}-mobile`]: mobile,
[`${prefixCls}-editable`]: editable,
Expand Down