Fix useComposeRef not found error #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
In case somebody else runs into this: I worked around this problem by providing the following in package.json (with yarn): |
|
@yiminghe 帮忙关注下 今天更新也遇到了 把antd版本回退到4.22.8可以正常运行 |
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 17 17
Lines 574 574
Branches 136 136
=======================================
Hits 572 572
Misses 2 2 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippotto
added a commit
to scalableminds/webknossos
that referenced
this pull request
Nov 2, 2022
philippotto
added a commit
to scalableminds/webknossos
that referenced
this pull request
Nov 2, 2022
* implement rudimentary magic selection tool via rectangle input and simple thresholding * improve ux for new tool * clean up * add n-dimensional-flood-fill and ndarray-convolve * add mocked predict function and begin with gathering input * ort cant create session from onnx file * more clean up * floodfill + dilate + erode * fine tune and measure time * use texture to preview found segment instead of immedialy labeling (unfortunately, only RGBA texture works for now) * clean up * add UI to finetune settings for magic wand with a live preview; highlight center of rect; always fill 10% rectangle around the seed * temporarily disable most CI checks * show create-segment and overwrite mode buttons in rectangle tool * remove onnx related code * write ts stubs for flood fill and morphology libs * add proper typing for watershed feature * rename rectangle to watershed tool * change watershed icon * remove unused copy plugin * more rectangle to watershed renaming * also rename saga file to watershed * adapt code to make the watershed preview optional (default to no preview) * add settings UI for watershed to control preview behavior and postprocessing values * suppress ts error * don't hardcode color layer name * generalize watershed feature to YZ and XZ viewports * generalize watershed to arbitrary bounding box * implement distance-field approach to segment dark segments * automatically detect whether bright or dark segment should be segmented * remove unused code * clean up preview texture * fix rotation of preview plane * tune default values and misc * add stubs for ndarray-moments * clean up * change color of preview rectangle to active segment color * fix quick-select when drawing rectangle larger than layer bounding box * allow to accept/discard from settings preview and disable options when they are irrelevant; update antd so that the popover can be closed on confirm/discard * fix type errors related to antd update * fix ndarray related type errors * allow to switch between dark and light segment detection mode in watershed settings * remove deprecation warnings for tipFormatter * use correct unthresholded input array when switching segment mode * more antd deprecations * remove unused computeHistogram code * fix linting * re-enable CI tests * use custom icon for quick select tool * fix disabled state for quick-select tool * improve quick select tool icon * fix antd rc-tabs problem after update by pinning rc-util * present threshold as % instead of uint8 intensity * fix getData for RGB; fix endless loop when creating thresholdField by maintaining visited bools separately; convert RGB to grayscale * hide contour and rectangle geometry in 3D viewport * rename watershed to quick select * pick first visible color layer for quick-select tool; convert non-uint8 to uint8 data as preprocessing step * allow to click undo to cancel a quickselect preview * improve typing * implement hole filling * fix linting * remove cyclic dependency which crashed several tests * change placement of quick-select tool in toolbar and fix corresponding tests * add yarn test-changed so that only the specs are executed which have a diff in git * remove unused n-dimensional-flood-fill.d.ts * improve typing in contour geometry and some general clean up * DRY quick select settings UI * dont crash when dragging into 3D viewport * remove console.logs * clean up and add comments to quick select saga * simplify some helper functions * simplify quick select saga a bit * further refactoring * use dark and light instead of min and max for threshold variables; add more comments * more renaming * update docs * rename contourgeometry module * implement rectangular border (sometimes renders weirdly, though) * remove buggy rectangular border again * fix zero-sized array access * update changelog * integrate PR feedback * Update frontend/javascripts/oxalis/model/sagas/quick_select_saga.ts Co-authored-by: Daniel <daniel.werner@scalableminds.com> * more feedback * fix type error * rename var for consistency * revert interface change in front-end api * fix that preview could disappear once the preview kicked in * hide rectangle geometry if plane is at another position even if clipping distance is huge * fix division-by-zero which caused disappearing preview when thresholds were extreme * fix offset bug in computing center view * start from area instead of point * rename rectangle geometry to QuickSelectGeometry * try to implement preview outline with separate plane geometries (still weird border widths and complicated implementation) * Revert "try to implement preview outline with separate plane geometries (still weird border widths and complicated implementation)" This reverts commit c349f9f. * implement preview outline by simply reusing the already existing data texture * improve typing when setting values for key-strings via reducer * improve typing when setting values for key-strings via reducer (2/2) * send analytics events when using quick select * rename var in comment * show info-toast when quick select preview is active * fix logic in filling center rectangle as preparation for constructing threshold field * allow to resize symmetrically when holding shift; highlight settings icon when preview is active * bump rc-tabs to 12.2.2 to avoid manual resolution See react-component/tabs#597 for context. Co-authored-by: Arthur Hilbert <arthur.hilbert@t-online.de> Co-authored-by: Daniel <daniel.werner@scalableminds.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced the usage of
useComposeRef(imported fromrc-util). However, according to the changelog, this function was only introduced in 5.16.0.rc-tabsonly requiresrc-util@^5.5.0which is why this module might not work under certain setups.For example, I get the following warning in webpack (which results in a run time exception when starting my web app):
Please merge my PR and create a new release of rc-tabs, as this is currently blocking me from upgrading antd to 4.23.6.