[WIP]Preact compat by pingan1927 · Pull Request #76 · react-component/tabs

pingan1927 · 2017-07-11T13:21:52Z

lint & test done.

原来写法preact会有问题，activeKey获取的不是最新值。

改了ref的写法，看看是否需要发大版本。

coveralls · 2017-07-11T13:29:17Z

Changes Unknown when pulling fb52de7 on preact-compat into ** on master**.

coveralls · 2017-07-12T02:13:29Z

Changes Unknown when pulling 32e3224 on preact-compat into ** on master**.

paranoidjk · 2017-07-12T02:32:49Z

ref #77 一并修复下算了 😄

pingan1927 · 2017-07-13T07:26:07Z

done. 那个pr是外国友人提交的？

coveralls · 2017-07-13T07:31:01Z

Changes Unknown when pulling 6b08174 on preact-compat into ** on master**.

paranoidjk · 2017-07-13T07:46:42Z

src/TabBarMixin.js

      }
      const key = child.key;
-      let cls = activeKey === key ? `${prefixCls}-tab-active` : '';
+      let cls = this.props.activeKey === key ? `${prefixCls}-tab-active` : '';


这个改动是为什么？应该没有区别？

事实是有区别的，搞了我一天，fml

不过这行代码可能没影响，但这个方法体内要改就全改了。

为什么... 分享下踩的坑

ping @pingan1927

不清楚原因的改动没法合的

ping @pingan1927

paranoidjk · 2017-07-13T07:48:12Z

src/InkTabBarMixin.js

  const containerOffset = offset(wrapNode);
  const inkBarNode = refs.inkBar;
-  const activeTab = refs.activeTab;
+  const activeTab = component.activeTab;


这个改动，rc-tabs 肯定是要升 major 的

不确定是不是有依赖 refs.activeTab

paranoidjk · 2017-07-13T07:52:02Z

close #77
@pingan1927 养成在 commit message 和 pr description 里面自动关闭对应issue的习惯 😄

see https://help.github.com/articles/closing-issues-via-commit-messages/

pingan1927 · 2017-07-28T02:50:25Z

src/SwipeableInkTabBar.js

        key={key}
-        {...refProps}
+        ref={(tab) => {
+          if (this.props.activeKey === key) {


关键的一点：外层定义的const activeKey = props.activeKey;在ref的callback执行的时候，不是预期中的值，已经变掉了。

直接取this.props.activeKey 就符合预期了

这怎么可能？你的意思是用户把 activeKey 改变了？callback 执行的时候拿到的是旧的值？

运行demo，把react 依赖换成preact配套的依赖，就可以重现了

paranoidjk · 2017-07-28T06:50:02Z

@pingan1927 rebase master, 我加了个 npm run start:preact，在你这个分支 npm start 正常，npm run start:preact 切换的时候 tabbar 显示不正常，你再检查下

paranoidjk · 2017-07-28T10:24:03Z

@pingan1927 rebase master, i fixed #77

coveralls · 2017-07-28T11:48:51Z

Coverage decreased (-0.2%) to 70.019% when pulling 9f17593 on preact-compat into 242b577 on master.

coveralls · 2017-07-28T11:53:53Z

Coverage decreased (-0.2%) to 70.019% when pulling 9f17593 on preact-compat into 242b577 on master.

pingan1927 · 2017-07-28T12:06:36Z

@paranoidjk done, test应该都是通过了的

paranoidjk

@pingan1927 测试要仔细一点。用真机测，在 preact 上，滑动 tab 内容切换 tab 失效了，切换回 react 没问题。

pingan1927 · 2017-08-02T05:49:44Z

哦？这两天忙完了继续看看

paranoidjk · 2017-08-17T02:04:33Z

@pingan1927 这个拖太久了，再不处理我就过期关掉了？

paranoidjk · 2017-08-17T02:15:35Z

这个我来处理算了。

coveralls · 2017-08-17T02:23:56Z

Coverage decreased (-1.0%) to 67.838% when pulling 22a216a on preact-compat into 8ab8bab on master.

coveralls · 2017-08-17T02:29:45Z

Coverage decreased (-0.9%) to 67.958% when pulling 22a216a on preact-compat into 8ab8bab on master.

coveralls · 2017-08-17T04:38:26Z

Coverage decreased (-0.9%) to 67.958% when pulling 9423f17 on preact-compat into 8ab8bab on master.

coveralls · 2017-08-17T08:15:28Z

Coverage decreased (-1.3%) to 67.483% when pulling 0ea9baf on preact-compat into 949c4d3 on master.

coveralls · 2017-08-17T10:51:28Z

Coverage decreased (-1.3%) to 67.483% when pulling e747eab on preact-compat into 949c4d3 on master.

paranoidjk · 2017-09-01T02:29:46Z

close. @zhang740 在重写 rmc-tabs. @zhang740 开发过程中可以用我 fork 的 rmc-tools https://github.com/paranoidjk/rc-tools#preact 测试下 preact 运行是否ok。

pingan1927 requested a review from paranoidjk July 12, 2017 02:21

paranoidjk reviewed Jul 13, 2017

View reviewed changes

paranoidjk self-assigned this Jul 13, 2017

pingan1927 mentioned this pull request Jul 14, 2017

code style #77

Closed

pingan1927 commented Jul 28, 2017

View reviewed changes

paranoidjk changed the title ~~Preact compat~~ [WIP]Preact compat Jul 28, 2017

pingan1927 mentioned this pull request Jul 28, 2017

[PREACT] antd-mobile适配Preact 问题收集 ant-design/ant-design-mobile#1304

Closed

9 tasks

pingan1927 force-pushed the preact-compat branch from ad05438 to 9f17593 Compare July 28, 2017 11:48

paranoidjk requested changes Jul 29, 2017

View reviewed changes

temu.psc added 3 commits August 17, 2017 10:19

适配preact

f0da199

clear code

71a4243

optimize code

965368f

paranoidjk force-pushed the preact-compat branch from 9f17593 to 965368f Compare August 17, 2017 02:19

fix: rebase

22a216a

paranoidjk force-pushed the preact-compat branch from 9423f17 to 0ea9baf Compare August 17, 2017 08:10

feat: use rmc-tools

e747eab

paranoidjk force-pushed the preact-compat branch from 0ea9baf to e747eab Compare August 17, 2017 10:43

paranoidjk closed this Sep 1, 2017

paranoidjk deleted the preact-compat branch September 1, 2017 02:29

Uh oh!

Conversation

pingan1927 commented Jul 11, 2017

Uh oh!

coveralls commented Jul 11, 2017

Uh oh!

coveralls commented Jul 12, 2017

Uh oh!

paranoidjk commented Jul 12, 2017

Uh oh!

pingan1927 commented Jul 13, 2017

Uh oh!

coveralls commented Jul 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paranoidjk commented Jul 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paranoidjk commented Jul 28, 2017

Uh oh!

paranoidjk commented Jul 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jul 28, 2017

Uh oh!

coveralls commented Jul 28, 2017

Uh oh!

pingan1927 commented Jul 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paranoidjk left a comment

Choose a reason for hiding this comment

Uh oh!

pingan1927 commented Aug 2, 2017

Uh oh!

paranoidjk commented Aug 17, 2017

Uh oh!

paranoidjk commented Aug 17, 2017

Uh oh!

coveralls commented Aug 17, 2017

Uh oh!

coveralls commented Aug 17, 2017

Uh oh!

coveralls commented Aug 17, 2017

Uh oh!

coveralls commented Aug 17, 2017

Uh oh!

coveralls commented Aug 17, 2017

Uh oh!

paranoidjk commented Sep 1, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

paranoidjk commented Jul 28, 2017 •

edited

Loading

pingan1927 commented Jul 28, 2017 •

edited

Loading