Skip to content

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 23, 2019

No description provided.

@afc163 afc163 requested a review from zombieJ December 23, 2019 07:58
@afc163 afc163 force-pushed the remove-IE8/9-support branch from 59f91df to 669240a Compare December 23, 2019 07:58
@coveralls
Copy link

Coverage Status

Coverage increased (+1.7%) to 82.517% when pulling 669240a on remove-IE8/9-support into 933012c on master.

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2019

This pull request fixes 4 alerts when merging 669240a into 933012c - view on LGTM.com

fixed alerts:

  • 2 for Direct state mutation
  • 1 for Useless assignment to local variable
  • 1 for Useless conditional

@afc163 afc163 merged commit c76832d into master Dec 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the remove-IE8/9-support branch December 23, 2019 08:04
@AmazingTurtle
Copy link
Contributor

@afc163 I looked into ant.design upload component which is using rc-upload. They mentioned a prop supportServerRender. I tried to look it up and found this commit where you removed it. However you forgot to update the doc for onReady prop, see here

@afc163
Copy link
Member Author

afc163 commented May 2, 2020

Could you help to update the doc?

@AmazingTurtle
Copy link
Contributor

I can help with updating the docs in this repo.

Regarding ant.design docs: I can't find the correct repo for that. Perhaps is it the main ant-design repository?

@afc163
Copy link
Member Author

afc163 commented May 2, 2020

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants