Skip to content

Conversation

@ihmpavel
Copy link
Contributor

@ihmpavel ihmpavel commented Apr 13, 2021

On some browsers, especially Microsoft Edge Legacy, version 17.x spreading NodeList throws an error, because NodeList is not-iterable instance. Polyfills does not work.

Babel issue: babel/babel#9993
Converting NodeList to an array: https://gomakethings.com/converting-a-nodelist-to-an-array-with-vanilla-javascript/

This pull request changes creating an Array from NodeList with Array.from instead of spreading to support as ancient browsers as IE6.

image

fix ant-design/ant-design#30234

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #226 (80262b1) into master (e02d5b0) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 80262b1 differs from pull request most recent head 8412e02. Consider uploading reports for the commit 8412e02 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   53.12%   53.12%           
=======================================
  Files          40       40           
  Lines         847      847           
  Branches      300      302    +2     
=======================================
  Hits          450      450           
  Misses        341      341           
  Partials       56       56           
Impacted Files Coverage Δ
src/Dom/dynamicCSS.ts 94.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02d5b0...8412e02. Read the comment docs.

@ihmpavel
Copy link
Contributor Author

Hi, it would be nice if someone could look into this.

Is it possible to merge it and bump to this version Ant Design?

Because of this bug, Icons breaks loading page in Edge v17 (see screenshots in the PR). It does not matter, if it is imported icon from @ant-design/icons or default PasswordInput with an eye icon.

On the requirements page of Ant Design, Edge should be supported browser.

Do I need to make some steps to reproduce this, make bug issue on Ant Design Github or something else?

Thank you in advance

@zombieJ @afc163

@yoyo837 yoyo837 merged commit 8330fd8 into react-component:master Apr 20, 2021
@zombieJ
Copy link
Member

zombieJ commented Apr 21, 2021

+ rc-util@5.9.9

@ihmpavel
Copy link
Contributor Author

Should I create PR for updating rc-util to 5.9.9 in Ant Design?

@yoyo837
Copy link
Member

yoyo837 commented Apr 21, 2021

Just remove node_modules and lock file, then reinstall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icons not working in Edge v17 (Invalid attempt to spread non-iterable instance) + PR

3 participants