Skip to content

Conversation

@yoyo837
Copy link
Member

@yoyo837 yoyo837 commented Jun 10, 2021

rc-select里的 useLayoutEffect 挪到rc-util

Prepare for
ant-design/ant-design#30396
react-component/overflow#6
react-component/select#614

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #252 (febba57) into master (ddba9d5) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   61.26%   61.44%   +0.17%     
==========================================
  Files          41       43       +2     
  Lines         883      887       +4     
  Branches      306      308       +2     
==========================================
+ Hits          541      545       +4     
  Misses        304      304              
  Partials       38       38              
Impacted Files Coverage Δ
src/hooks/useLayoutEffect.ts 100.00% <100.00%> (ø)
src/isBrowserClient.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddba9d5...febba57. Read the comment docs.

@yoyo837
Copy link
Member Author

yoyo837 commented Jun 10, 2021

如果合并,我再改其他的。

import canUseDom from './Dom/canUseDom';

/** Is client side and not jsdom */
export default process.env.NODE_ENV !== 'test' && canUseDom();
Copy link
Member

@zombieJ zombieJ Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test env also pass canUseDom

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoyo837 这个不行啊,process 不一定存在的。

@zombieJ zombieJ merged commit db66375 into master Nov 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-some-hook branch November 10, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants