Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/hooks/useLayoutEffect.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/* eslint-disable react-hooks/rules-of-hooks */
import * as React from 'react';
import isBrowserClient from '../isBrowserClient';

/**
* Wrap `React.useLayoutEffect` which will not throw warning message in test env
*/
export default function useLayoutEffect(effect: React.EffectCallback, deps?: React.DependencyList) {
// Never happen in test env
if (isBrowserClient) {
/* istanbul ignore next */
React.useLayoutEffect(effect, deps);
} else {
React.useEffect(effect, deps);
}
}
/* eslint-enable */
4 changes: 4 additions & 0 deletions src/isBrowserClient.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import canUseDom from './Dom/canUseDom';

/** Is client side and not jsdom */
export default process.env.NODE_ENV !== 'test' && canUseDom();
Copy link
Member

@zombieJ zombieJ Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test env also pass canUseDom

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoyo837 这个不行啊,process 不一定存在的。

33 changes: 33 additions & 0 deletions tests/hooks.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import * as React from 'react';
import { mount } from 'enzyme';
import useMemo from '../src/hooks/useMemo';
import useMergedState from '../src/hooks/useMergedState';
import useLayoutEffect from '../src/hooks/useLayoutEffect';

describe('hooks', () => {
it('useMemo', () => {
Expand Down Expand Up @@ -56,4 +57,36 @@ describe('hooks', () => {
expect(wrapper.find('input').props().value).toEqual('test');
});
});

describe('useLayoutEffect', () => {
const FC = ({ defaultValue }) => {
const [val, setVal] = React.useState(defaultValue);
const [val2, setVal2] = React.useState();
useLayoutEffect(() => {
setVal2(`${val}a`);
}, [val]);
return (
<div>
<input
value={val}
onChange={e => {
setVal(e.target.value);
}}
/>
<label>{val2}</label>
</div>
);
};

it('correct effect', () => {
const wrapper = mount(<FC defaultValue="test" />);
expect(wrapper.find('label').props().children).toEqual('testa');
wrapper.find('input').simulate('change', { target: { value: '1' } });
wrapper.update();
expect(wrapper.find('label').props().children).toEqual('1a');
wrapper.find('input').simulate('change', { target: { value: '2' } });
wrapper.update();
expect(wrapper.find('label').props().children).toEqual('2a');
});
});
});