Skip to content

Conversation

li-jia-nan
Copy link
Member

remove javascript , use typescript rewrite

@vercel
Copy link

vercel bot commented Aug 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
util ✅ Ready (Inspect) Visit Preview Aug 24, 2022 at 4:44PM (UTC)

@li-jia-nan
Copy link
Member Author

@zombieJ @afc163 用ts重写了一下,大佬麻烦review一下

@zombieJ
Copy link
Member

zombieJ commented Aug 22, 2022

js -> ts 的 revert 一下,那些不改是因为方便未来重构的时候把长久没用的代码舍弃掉。ts 定义补充的可以合之~

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 22, 2022

This pull request introduces 4 alerts when merging 03672a5 into 99e3753 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@li-jia-nan
Copy link
Member Author

js -> ts 的 revert 一下,那些不改是因为方便未来重构的时候把长久没用的代码舍弃掉。ts 定义补充的可以合之~

reverted

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #329 (256311d) into master (99e3753) will not change coverage.
The diff coverage is 60.86%.

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   67.43%   67.43%           
=======================================
  Files          47       47           
  Lines        1035     1035           
  Branches      339      343    +4     
=======================================
  Hits          698      698           
+ Misses        299      298    -1     
- Partials       38       39    +1     
Impacted Files Coverage Δ
src/deprecated.js 0.00% <ø> (ø)
src/isMobile.ts 0.00% <0.00%> (ø)
src/Dom/isVisible.ts 28.57% <14.28%> (ø)
src/Dom/scrollLocker.ts 96.49% <50.00%> (-3.51%) ⬇️
src/Children/toArray.ts 83.33% <100.00%> (ø)
src/Dom/dynamicCSS.ts 96.00% <100.00%> (ø)
src/Dom/focus.ts 57.14% <100.00%> (ø)
src/composeProps.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@li-jia-nan li-jia-nan requested a review from zombieJ August 24, 2022 16:42
@zombieJ zombieJ merged commit 780a217 into react-component:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants