[codex] upgrade tests to React 18#359
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedPull request was closed or merged during review Walkthrough本 PR 升级 package.json 中的 peer/dev 依赖以支持 React 18,并将大量测试从 Enzyme 重写为 Changes依赖升级与测试迁移
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 19 19
Lines 796 796
Branches 189 191 +2
=======================================
Hits 776 776
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the project to React 18, updating peer and development dependencies including React, React DOM, and testing libraries like @testing-library/react and enzyme. Additionally, it updates test files to wrap scrollTo calls within act() blocks to ensure compatibility with React 18's rendering behavior. I have no feedback to provide as there were no review comments.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
eb6a208 to
4e7fda9
Compare
Summary
Validation
npm run lintbunx tsc --noEmitnpm run compilebun run test -- --coverage --silentSummary by CodeRabbit
兼容性更新
开发依赖
测试