Fix fetch mocking in Apollo test #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavxyz
approved these changes
Mar 17, 2018
Contributor
xavxyz
left a comment
xavxyz
left a comment
There was a problem hiding this comment.
Stateless for the win, cheers
|
|
||
| // used under the hood by HttpLink | ||
| global.fetch = fetch; | ||
| global.fetch = fetchMock.fetchMock; |
xavxyz
added a commit
that referenced
this pull request
Mar 17, 2018
* refactor: update to apollo client 2 & cie (#445) * feat: make it possible to pass a link or a schema to configure the apollo proxy (#445) * feat: connect apollo devtools to the proxy cache (#445) * chore: clean example (#445) * feat: broadcast apollo cache changes to fixture editor (#445) * feat: update apollo proxy options: endpoint, client, schema (#445) * feat: throw with link to docs if apollo proxy is not well configured (#445) * feat: remove apollo cache broadcast (#445) # even if it was pretty fun! it's not that useful haha * chore: simplify apollo proxy examples (#445) * feat: fixture link to mock apollo response from the fxture (#445) * fix: make fixture link replace any link after creating the client (#445) * feat: simplify API, remove schema link (#445) * feat: support named operation * chore: update dependencies * feat: make it possible to mock a mutation result * chore: fix lint * feat: enable the apollo devtools (#552) * test: throw if the client is not configured (#552) * test: proxy configured with a client (#552) * test: uses a default http link if the fixture is not mocked (#552) * test: fixture link (#552) * feat: pass the entire fixture to the resolveWith fn * fix: only replace the link if the fixture is mocked (#445) * docs: update Apollo proxy docs (#445) * docs: show how to mock an error response from Apollo * Fix Node 6 incompatibilities (#619) * Downgrade fetch-mock * Replace Object.entries * fix: update per @skidding review 🙌 * Simplify local Apollo server (#621) * Simplify local Apoll server * Remove yarn-error.log * Update Apollo example instructions * Fix fetch mocking in Apollo test (#622) * Fix fetch mocking in Apollo test * Add babel-cli dev dep to Apollo example * Remove node-fetch from ApolloProxy's dev deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.