Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mariepw's PR removed the condition that the calendar must be horizontal to apply width styling. This broke vertical calendar widths by forcing them to be the width that they would be if they were horizontal and also by making it
inline-block.Here's the problem line: https://github.com/airbnb/react-dates/pull/989/files#diff-883056b4b11263241c339f927e93411bR818
Also, I removed a style object that didn't exist,
DayPicker__vertical.Here's what the calendar looked like:
Here's what it should look like:
reviewers: @majapw