new react getDerivedStateFromProps #107
Conversation
|
Would be good to get this to |
|
@STRML cool I've updated the PR to use |
rvdende
changed the title
this package uses flowtype (not typescript), that's why we use .js extension instead of .ts |
|
ah I see, thanks for the comment @daynin |
| }); | ||
| } | ||
| if (!state.resizing && | ||
| (props.width !== props.width || props.height !== props.height)) { |
There was a problem hiding this comment.
It won't work
props.width !== props.width // false (always, except cases with NaN)you should use componentDidMount here
| height: nextProps.height | ||
| }); | ||
| static getDerivedStateFromProps(props: ResizableProps, state:Object) { | ||
| if (props.width !== props.width || props.height !== props.height) { |
|
The |
| }); | ||
| } | ||
| if (!state.resizing && | ||
| (props.width !== props.width || props.height !== props.height)) { |
There was a problem hiding this comment.
This comparison doesn't make sense. You don't have access to the previous props. See react-grid-layout/react-draggable@fea778c
| }; | ||
|
|
||
| componentWillReceiveProps(nextProps: Object) { | ||
| static getDerivedStateFromProps(props: Object, state:Object) { |
There was a problem hiding this comment.
Should use Props & State types
|
Closing in favor of #112 |
* refactor(Resizable): remove draggable state This must have been a vestigal bit of state from before the Resizable/ResizableBox refactor years ago. It is not actually needed and with the React 16.9 refactor to remove CWRP, it became obvious it was actually not useful. Fixes #99 Supersedes #100 Partially fixes #107, #110 * fix(ResizableBox): Fix 16.9 CWRP deprecation
4 participants
Just a simple quick fix to get rid of the react 17.x messages. If you guys think this is not the best way to resolve it and would rather go the componentDidUpdate route feel free to delete this PR.