Adding more docs and new components #976
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ), | ||
| } | ||
|
|
||
| const admonition = cva(styles.admonition, { |
There was a problem hiding this comment.
switch to img tag instead of inline svg?
There was a problem hiding this comment.
Here are my inspirations:
- https://github.com/facebook/docusaurus/blob/7d033cc8c08e0c8fd57baff7390540def6eb6046/packages/docusaurus-theme-classic/src/theme/Admonition/Icon/Caution.tsx
- https://github.com/nebrelbug/react-admonitions/blob/master/src/index.js#L46
What are the benefits of an img tag vs inline svg?
There was a problem hiding this comment.
I believe I did it this way because there is SOME styling applied to the SVGs. Can that be done with inline img?
There was a problem hiding this comment.
no worries, img is normally better than inline svg, with better perf, and better cache, but don't worry about it. Large PR I will continue my review.
There was a problem hiding this comment.
Again, I'm sorry for the large PR's :(
There was a problem hiding this comment.
Not at all, thanks for soring everything out and making a huge improvement on the site.
bluebill1049
left a comment
bluebill1049
left a comment
There was a problem hiding this comment.
looks so good, i love those
2 participants
New content
Edited content:
Other changes added:
Found 27 errors in 5 files.
Errors Files
17 src/components/ApiRefTable.tsx:141
5 src/components/BuilderPage.tsx:99
1 src/components/CodeCompareSection.tsx:74
1 src/components/DevTools.tsx:116
3 src/components/Form.tsx:174