Conversation
| "keywords": [ | ||
| "react", | ||
| "hooks", | ||
| "react-hooks" | ||
| ], |
| import { | ||
| FieldErrors, | ||
| FieldName, | ||
| Message, | ||
| MultipleFieldErrors, | ||
| AsProps, | ||
| Assign, | ||
| } from 'react-hook-form'; |
There was a problem hiding this comment.
@bluebill1049 Should I fix core lib to export types?
There was a problem hiding this comment.
i think we can duplicate those types here if they are not essential for users. what do you think?
There was a problem hiding this comment.
this component probably not going to be touched after release for a while.
| "keywords": [ | ||
| "react", | ||
| "react-component", | ||
| "form", | ||
| "forms", | ||
| "form-validation", | ||
| "validation", | ||
| "hookform", | ||
| "react-hook-form", | ||
| "typescript" | ||
| ], |
There was a problem hiding this comment.
@bluebill1049 What do you think this keywords?
| { | ||
| input: 'src/index.tsx', | ||
| output: { | ||
| name: 'HookFormErrorMessage', |
There was a problem hiding this comment.
@bluebill1049 What do you think this umd global naming?
HookFormErrorMessage vs ErrorMessage
There was a problem hiding this comment.
ReactHookFormErrorMessage ? keep consistent?
bluebill1049
left a comment
bluebill1049
left a comment
There was a problem hiding this comment.
Awesome! Nice ErrorMessage! let's publish it.
|
yea! I will publish it! 🚀 |
|
sounds good @kotarella1110 🚀 |
|
🎉 This PR is included in version 0.0.1 🎉 |
|
awesome! |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
remove
ErrorMessagecomponent from core lib in v6 (react-hook-form/react-hook-form#1471).move back to its this repo.
Reason: TS support is getting better with optional chaining and we could trim some size off our lib size without impacting the end-user experience of rendering errors
See this issue (react-hook-form/react-hook-form#1840) for more detail.