Changes in 7.20.3 seem to cause useFieldArray changes to make all fields dirtyFields

[dbousamra]

Version Number

7.20.3

Codesandbox/Expo snack

https://codesandbox.io/s/react-hook-form-submit-only-dirty-fields-forked-o6yc4?file=/src/index.tsx

Steps to reproduce

If you append/remove a field array value, you will notice the dirty fields are a different format to what they were previously. Not such an issue, but this function:

const getDirtyValues = (
  dirtyFields: UnknownArrayOrObject | boolean,
  allValues: UnknownArrayOrObject,
): UnknownArrayOrObject => {
  // NOTE: Recursive function.

  // If *any* item in an array was modified, the entire array must be submitted, because there's no
  // way to indicate "placeholders" for unchanged elements. `dirtyFields` is `true` for leaves.
  if (dirtyFields === true || Array.isArray(dirtyFields)) {
    return allValues;
  }

  return Object.fromEntries(
    // @ts-ignore
    Object.keys(dirtyFields).map((key) => [key, getDirtyValues(dirtyFields[key], allValues[key])]),
  );
};

Which is floating around in an official example, and also this discussion: #1991

I spent ages trying to fix the function but I ran out of time.

Expected behaviour

I expect when I modify an array field, that the othern on array fields are not dirty

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[bluebill1049]

There was issue with the original implementation and hence the fix: #7109

dirty fields have been marked correctly as well.

Which is floating around in an official example,

Share the link? I don't think that's an official solution.

[dbousamra]

https://github.com/react-hook-form/react-hook-form/blob/master/examples/V7/dirtyFieldsOnlySubmitted.tsx

[bluebill1049]

https://github.com/react-hook-form/react-hook-form/blob/master/examples/V7/dirtyFieldsOnlySubmitted.tsx

Removed, this example was from the community.

[dbousamra]

Hmm. Is it possible to fix the function? I depend on it, but I could not figure out how to get it working. It should be so simple, but the recursion was doing my head in.

[bluebill1049]

As far as functionality goes with formate, the current dirty fields fix the field array issue (the issue which i have pointed out above), if this is blocking I recommend using the previous version for now.

[dbousamra]

Okay, so stay with 7.20.2. That's fine. Thanks!

[bluebill1049]

Thanks for understanding. We will keep it as it is for now, as it fixes the issue with incorrect field array reporting which is a pretty bad bug causing app crash.

[dbousamra]

@bluebill1049 any updates here? I want to upgrade, but I am still seeing this issue where all fields are marked dirty for field arrays.

[rostber]

The 7.28.1 version has had that problem yet.