Skip to content

Conversation

@jorisre
Copy link
Member

@jorisre jorisre commented Feb 5, 2021

I removed one test because it couldn't occur with an object schema. Let me know if I'm wrong

@jorisre jorisre requested a review from bluebill1049 February 5, 2021 14:43
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2021

Size Change: -804 B (-7%) ✅

Total Size: 11 kB

Filename Size Change
yup/dist/yup.js 543 B -212 B (-28%) 🎉
yup/dist/yup.modern.js 474 B -176 B (-27%) 🎉
yup/dist/yup.module.js 556 B -213 B (-28%) 🎉
yup/dist/yup.umd.js 645 B -203 B (-24%) 🎉
ℹ️ View Unchanged
Filename Size Change
dist/resolvers.js 272 B 0 B
dist/resolvers.modern.js 281 B 0 B
dist/resolvers.module.js 285 B 0 B
dist/resolvers.umd.js 367 B 0 B
joi/dist/joi.js 708 B 0 B
joi/dist/joi.modern.js 586 B 0 B
joi/dist/joi.module.js 720 B 0 B
joi/dist/joi.umd.js 806 B 0 B
superstruct/dist/superstruct.js 269 B 0 B
superstruct/dist/superstruct.modern.js 274 B 0 B
superstruct/dist/superstruct.module.js 282 B 0 B
superstruct/dist/superstruct.umd.js 367 B 0 B
vest/dist/vest.js 419 B 0 B
vest/dist/vest.modern.js 335 B 0 B
vest/dist/vest.module.js 389 B 0 B
vest/dist/vest.umd.js 508 B 0 B
zod/dist/zod.js 470 B 0 B
zod/dist/zod.modern.js 408 B 0 B
zod/dist/zod.module.js 485 B 0 B
zod/dist/zod.umd.js 578 B 0 B

compressed-size-action

"license": "MIT",
"peerDependencies": {
"react-hook-form": ">=6.6.0"
"react-hook-form": ">=6.6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI:I think with the latest update (i will move to 7) there are breaking changes.

@bluebill1049
Copy link
Member

I removed one test because it couldn't occur with an object schema. Let me know if I'm wrong

👍

Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome cleanup and bundle size reduction.

@jorisre jorisre merged commit de0b62a into beta Feb 6, 2021
@jorisre jorisre deleted the reduce-yup-resolver-size branch February 6, 2021 08:15
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2021

🎉 This PR is included in version 2.0.0-beta.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jorisre jorisre mentioned this pull request Feb 14, 2021
5 tasks
jorisre added a commit that referenced this pull request Apr 2, 2021
* feat: V2 init

BREAKING CHANGE: there will be some breaking changes in the next versions

* feat: improve modules support

* fix: yup resolver typescript errors

* Fix: vest validate all criteria + better TypeSript support + add tests

* test: add components test to ensure TypeScript is working as expected

Related to #97

* chore: improve zod resolvers types

* chore(eslint): remove warnings

* test: add severals tests & improve typings

* chore: setup compressed-size

* test: update describe

* feat: add Zod sync validation (#114)

* feat: add Joi sync validation (#116)

* feat: add Joi sync validation

* fix(joi): sync error

* test: add validateAllCriteria test

* test(joi): update test description

* feat: add Yup sync validation (#115)

* feat: add Yup sync validation

* test(zod): add tests

* test(zod): update tests

* test(yup): add validateAllCriteria test

* feat: add Vest sync validation + update to v3 (#117)

* feat: update to react-hook-form v7

BREAKING CHANGE: Require react-hook-form >= 7

* chore: fix typescript error (#123)

* chore: update deps

* chore: fix TypeScript error

* refactor: replace deprecated transformToNestObject (#125)

* fix: pass down Joi context (#124)

* fix: zod union error + reduce size (#126)

* test: extract fixtures

* fix: zod resolver union error + reduce resolver size

* feat: add error's ref (#127)

* feat: add error's ref

* test: add error's ref + extract fixtures

* test: add nested test

* refactor: rename toNestObject to toNestError

* Reduce superstruct resolver size (#128)

* test: extract test's fixtures

* test: jest fixtures config

* perf: reduce superstruct resolver size

* feat: add error's ref

* test: add error's ref + extract fixtures

* test: add nested test

* refactor: rename toNestObject to toNestError

* refactor: remove duplicate line

* chore: update superstruct peer dep

* perf: reduce vest resolver size (#129)

* test: extract test's fixtures

* test: jest fixtures config

* perf: reduce superstruct resolver size

* feat: add error's ref

* test: add error's ref + extract fixtures

* test: add nested test

* refactor: rename toNestObject to toNestError

* refactor: remove duplicate line

* perf: recude vest resolver bundle size

* perf: reduce joi resolver's size (#131)

* perf: reduce Joi resolver's size

* perf: reduce Vest resolver's size

* perf: reduce yup resolver's size (#130)

* refactor: remove convertArrayToPathName (#132)

* perf: reduce joi and yup bundle size (#134)

* fix(types): add Lazy schema support to resolver

* docs: v2 doc (#136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants