Fix API typos #400
Merged
Fix API typos #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you explain why you think this is a typo? |
Contributor
Author
|
"can be also rejects"? It looks like the author wanted to type "can be also rejected". I didn't change to that because "can be also" is totally unnecessary due to "in case of". If you really want the "can also be" to stay, then it should at least be "can be also rejected" |
Contributor
Author
|
On second thought it actually should be "rejecting in case(...)" to match the tense from the previous line which starts with "resolving" |
Contributor
Author
|
I updated the PR to "can also be rejected" for middle ground :) |
Member
Appreciated 🙏 |
krizzu
approved these changes
Jul 12, 2020
djhr
pushed a commit
to smartHelios/async-storage
that referenced
this pull request
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix API typos
Test Plan:
No test required