config file read fails

[ShaMan123]

Environment

System:
OS: Windows 10
CPU: (4) x64 Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
Memory: 1.23 GB / 7.87 GB
Binaries:
Node: 8.16.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.16.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.10.1 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version 3.4.0.0 AI-183.6156.11.34.5692245

Description

when specifying dependency.platforms.android.folder | dependency.platforms.android.sourceDir config read fails

related to #518

[thymikee]

It's platforms (plural), not platform: https://github.com/react-native-community/cli/blob/master/docs/dependencies.md#platforms

[ShaMan123]

It's a typo that doesn't exist in the config file.
edited comment

module.exports = {
    dependency: {
        platforms: {
            android: {
                ///  specifying folder/sourceDir causes the entire file to not being read
                packageImportPath: "import io.autodidact.rnmathview.RNMathViewPackage;",
                packageInstance: "new RNMathViewPackage()"
            },
            ios: {}
        },
        assets: [],
    },
};

[thymikee]

Can you send a repro we can download and investigate?

[ShaMan123]

In the following repo I don't need these options but when I migrated to RN0.60 I didn't know that so I specified the fields which resulted in a bug.

steps to reproduce:

1. clone/download react-native-math-view
2. change react-native.config.js as described above to reproduce the bug, adding folder | sourceDir to dependency.platforms.android
3. run the example app on android example app instructions.

[thymikee]

I cannot repro. Setting sourceDir works just fine:

module.exports = {
  dependency: {
    platforms: {
      android: {
        sourceDir: 'android',
        packageImportPath: 'import io.autodidact.rnmathview.RNMathViewPackage;',
      },
    },
  },
};

As a result I can see the output in react-native config run from package that imports react-native-math-view:

FYI, folder is not configurable, as per https://github.com/react-native-community/cli/blob/5199d6af1aa6dc5d8dfb4a98e675987272d68998/docs/dependencies.md#platforms

[ShaMan123]

Documentation is rather confusing.
But none the less autolinking is a major step forward!
Thanks for the follow up

[thymikee]

@ShaMan123 psst, we accept PRs to improve the docs 😉 it's a joined effort and every contribution counts.