chore: use a better threshold factor to find the closest match #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
requested review from
Esemesek,
grabbou and
thymikee
as code owners
thymikee
approved these changes
Feb 22, 2020
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Awesome! While we're at it, can you add a test? Can be a followup PR, no biggie :)
Contributor
Author
|
Ig we can land this one for now, and I can shoot a follow up PR as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up of #960
Set the threshold to 40% such that
infoshows up instead in the above scenario.