chore: migrate to leven to find the closest match #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
requested review from
Esemesek,
grabbou and
thymikee
as code owners
grabbou
reviewed
Feb 16, 2020
grabbou
requested changes
Feb 16, 2020
Member
grabbou
left a comment
grabbou
left a comment
There was a problem hiding this comment.
Looks good overall, thanks for sending it over! Left some requests for changes, let's discuss!
jamesgeorge007
requested review from
grabbou and
thymikee
and removed request for
Esemesek and
thymikee
thymikee
approved these changes
Feb 21, 2020
This was referenced Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
closes #959
didyoumean.jsis not actively maintained anymore. Henceforth it is a good idea migrating toleven.