chore: set correct react-native peer dependency #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabbou
reviewed
Mar 4, 2020
packages/cli/package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "react-native": "^0.61.0" | ||
| "react-native": "^0.62.0" |
Member
There was a problem hiding this comment.
Why don't we do || 0.62.0-rc.3 or similar to remove warnings for RC versions as well? I don't think this would hurt.
Member
There was a problem hiding this comment.
Simple answer would be that we just don't care, which is fine as well
Member
Author
There was a problem hiding this comment.
Ok, went with including RC as well because we support it after all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This will still result in warnings for RC versions, but that's fine
cc @alloy
Test Plan:
None