fix: bootSimulator to use simclt instead of deprecated instruments #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Oct 15, 2021
rborn
force-pushed
the
fix/bootSimulator
branch
from
6b796f6 to
531040a
Compare
Contributor
Author
|
@thymikee mmm, not sure why react-native-community.cli test is failing ( it tries to start xcrun on a windows machine? ) |
Member
|
It fails all the time, don't bother :) |
thymikee
approved these changes
Oct 18, 2021
thymikee
changed the title
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1474 and facebook/react-native#32255 (comment)
Summary:
With Xcode 13
react-native run-ios --simulator [simulatorName]won't boot a new simulator if Simulator.app is already running but the selected sim is not booted.This PR should fix this (instrument is deprecated in Xcode 13, we replace it with a simctl command )
Test Plan:
How to reproduce the issue:
yarn run react-native run-ios --simulator='iPhone 11 Pro'yarn run react-native run-ios --simulator='iPhone 11 Pro'The simulator will not boot again
Or
yarn run react-native run-ios --simulator='iPhone 11 Pro'yarn run react-native run-ios --simulator='iPhone 7'The new iPhone 7 simulator won't boot.
With this PR
Both cases from above should work fine