Skip to content

fix: bootSimulator to use simclt instead of deprecated instruments #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2021
Merged

fix: bootSimulator to use simclt instead of deprecated instruments #1484

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a68d209
Fix bootSimulator to use simclt instead of deprecated instruments
Oct 15, 2021
d9465d5
Remove try/catch after removing instruments
Oct 18, 2021
531040a
linting
Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions packages/platform-ios/src/commands/runIOS/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,16 +397,8 @@ function buildProject(
function bootSimulator(selectedSimulator: Device) {
const simulatorFullName = formattedDeviceName(selectedSimulator);
logger.info(`Launching ${simulatorFullName}`);
try {
child_process.spawnSync('xcrun', [
'instruments',
'-w',
selectedSimulator.udid,
]);
} catch (_ignored) {
// instruments always fail with 255 because it expects more arguments,
// but we want it to only launch the simulator
}

child_process.spawnSync('xcrun', ['simctl', 'boot', selectedSimulator.udid]);
}

function getTargetPaths(buildSettings: string) {
Expand Down