Skip to content

feat: add condition for min node version #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 21, 2022
Merged

feat: add condition for min node version #1782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a008119
feat: add condition for min node version
szymonrybczak Dec 20, 2022
4b8ee78
fix: change way to get node version
szymonrybczak Dec 20, 2022
8d92551
fix: use min node version from versionRanges
szymonrybczak Dec 20, 2022
61a0f6b
chore: change error message
szymonrybczak Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli-doctor/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ export const commands = {info, doctor};
* We should not rely on this file from other packages, e.g. CLI. We probably need to
* refactor the init in order to remove that connection.
*/
export {default as versionRanges} from './tools/versionRanges';
export {default as installPods} from './tools/installPods';
16 changes: 13 additions & 3 deletions packages/cli/src/bin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
#!/usr/bin/env node

import './tools/gracefulifyFs';
import semver from 'semver';
import chalk from 'chalk';
import {versionRanges} from '@react-native-community/cli-doctor';

import {run} from './';

run();
if (semver.satisfies(process.version, versionRanges.NODE_JS)) {
const {run} = require('./');
run();
} else {
console.error(
`${chalk.red(
`React Native needs Node.js ${versionRanges.NODE_JS}. You're currently on version ${process.version}. Please upgrade Node.js to a supported version and try again.`,
)}`,
);
}