Skip to content

fix: config.reporter undefined bug #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2019
Merged

fix: config.reporter undefined bug #376

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a123c9
fix: config.reporter undefined bug
yinhangfeng May 7, 2019
35f5e52
refactor
thymikee May 7, 2019
e8af83e
Update loadMetroConfig.js
grabbou May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/cli/src/tools/loadMetroConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,18 @@ export type ConfigOptionsT = {|
*/
export default function load(ctx: ConfigT, options?: ConfigOptionsT) {
const defaultConfig = getDefaultConfig(ctx);
return loadConfig(
{cwd: ctx.root, ...options},
{...defaultConfig, reporter: options && options.reporter},
);
if (options && options.reporter) {
/**
* $FlowIssue: Metro doesn't accept `reporter` to be passed along other options
* and will ignore the value, if provided.
*
* We explicitly read `reporter` value and set it on a default configuration. Note
* that all other options described in the `ConfigOptionsT` are handled by Metro
* automatically.
*
* This is a temporary workaround.
*/
defaultConfig.reporter = options.reporter;
}
return loadConfig({cwd: ctx.root, ...options}, defaultConfig);
}