Skip to content

fix: cache lazy project getter for perf when accessed repeatedly #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2019
Merged

fix: cache lazy project getter for perf when accessed repeatedly #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/cli/src/tools/config/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ function getDependencyConfig(
* Loads CLI configuration
*/
function loadConfig(projectRoot: string = process.cwd()): ConfigT {
let lazyProject;
const userConfig = readConfigFromDisk(projectRoot);

const initialConfig: ConfigT = {
Expand All @@ -84,14 +85,19 @@ function loadConfig(projectRoot: string = process.cwd()): ConfigT {
platforms: Object.keys(userConfig.platforms),
},
get project() {
const project = {};
if (lazyProject) {
return lazyProject;
}

lazyProject = {};
for (const platform in finalConfig.platforms) {
project[platform] = finalConfig.platforms[platform].projectConfig(
lazyProject[platform] = finalConfig.platforms[platform].projectConfig(
projectRoot,
userConfig.project[platform] || {},
);
}
return project;

return lazyProject;
},
};

Expand Down