fix: better package class name regex on Android #525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Regex that is used for finding class name of ReactPackage doesn't support custom formatting and implementation of more than one interface
Current regex doesn't work for code like this:
because there is no whitespace between
ReactNativeSamplePackageand:Module is not linked also when package class implements other interface before ReactPackage one
Test Plan:
Green tests
Try autolink module with package class like below