Skip to content

adding projectRoot to options and resolve it #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2019
Merged

adding projectRoot to options and resolve it #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59c39a8
adding projectRoot to options and resolve it
lior-frezi Jul 25, 2019
8d92a3a
fixing flow error
lior-frezi Jul 28, 2019
2b624d6
adding --projectRoot to commands.md
lior-frezi Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/commands.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,10 @@ Starts the server that communicates with connected devices

Specify port to listen on

#### `--projectRoot [list]`
Copy link
Contributor

@mmerickel mmerickel Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't actually a list is it? looks like it's just forwarded to path.resolve() which doesn't take a list

Copy link
Member

@thymikee thymikee Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, it's a string. Mind sending a PR?

Copy link
Contributor

@mmerickel mmerickel Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#632


Path to a custom project root

#### `--watchFolders [list]`

Specify any additional folders to be added to the watch list
Expand Down
8 changes: 7 additions & 1 deletion packages/cli/src/commands/server/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,17 @@ export default {
name: '--host [string]',
default: '',
},
{
name: '--projectRoot [path]',
description: 'Path to a custom project root',
parse: (val: string) => path.resolve(val),
},
{
name: '--watchFolders [list]',
description:
'Specify any additional folders to be added to the watch list',
parse: (val: string) => val.split(','),
parse: (val: string) =>
val.split(',').map<string>((folder: string) => path.resolve(folder)),
},
{
name: '--assetPlugins [list]',
Expand Down