fix: fallback to default terminal if wrong one passed #601
Conversation
| description: | ||
| 'Launches the Metro Bundler in a new window using the specified terminal path.', | ||
| default: getDefaultUserTerminal, | ||
| default: getDefaultUserTerminal(), |
There was a problem hiding this comment.
How was it working previously?
There was a problem hiding this comment.
it either didn't or used open/sh to open with a default program
* origin/master: imp: optimize gradle code generation (#603) v2.8.2 fix: corrects `srcDirs` to be compatible with Kotlin projects (#602) v2.8.1 fix: fallback to default terminal if wrong one passed (#601) fix: adding back `projectRoot` to option (#588) fix: init run instructions to show workspace (#566)
|
Hello @thymikee , When I see "Checks" tab it seems to me that built has failed :/ We are struggling with this issue since we upgraded RN to 0.60.4 and it is not running the packager unless we explicitly specify |
|
@samuelgranja please describe your issue in detail. Ideally create a new one, with a repro we can download and investigate, describe environment, etc. Otherwise, it's not really actionable. |
|
Hi @thymikee, why this approach is only implemented for android? With the new version |
|
@Jeangel I guess one of the reasons may be that nobody sent a PR 😉 |
Summary:
It may happen, that the terminal detected by CLI or passed by the user is wrong and not really an executable. A good example is
vscode, which setsTERM_PROGRAMenv var tovscode, which is neither a command, nor a macOS app name. This PR introduces a fallback behavior for such cases, so that the terminal will be opened by a defaultopenprogram. If that doesn't work, we produce a warning with directions on what to do now:Test Plan:
Packager should start in new terminal window, when running
run-androidfromvscodeor any other terminal.