Skip to content

Fix tests on windows #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 4, 2019
Merged

Fix tests on windows #606

merged 10 commits into from
Aug 4, 2019

Conversation

@thecodrr
Copy link
Contributor

@thecodrr thecodrr commented Aug 2, 2019

Summary:

This fixes all the failing tests on Windows.

Test Plan:

Ran yarn test on Windows and everything passed.

@thymikee
Copy link
Member

thymikee commented Aug 2, 2019

Looks like we need to sort the output in the init e2e test

@thecodrr
Copy link
Contributor Author

thecodrr commented Aug 2, 2019 •
edited
Loading

The tests that check templateFiles fail due to incorrect order of files in the directory. Other fail due to incorrect output. toEqual is too strict it seems, we need a little flexible condition, maybe toHaveLength or toContain or maybe check all items individually? We could also create a separatetemplateFiles array for Windows.

@thymikee
Copy link
Member

thymikee commented Aug 2, 2019

Last failure left

thymikee
thymikee reviewed Aug 2, 2019
View reviewed changes
thymikee
thymikee reviewed Aug 3, 2019
View reviewed changes
thymikee
thymikee approved these changes Aug 4, 2019
View reviewed changes
packages/cli/src/commands/init/init.js
}

await fs.emptyDir(directory);
fs.emptyDirSync(directory);
Copy link
Member

@thymikee thymikee Aug 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, why this change?

Copy link
Contributor Author

@thecodrr thecodrr Aug 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using await causes hang on Windows, that's why.

Copy link
Member

@thymikee thymikee Aug 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geez, Windows is so weird

Copy link
Contributor Author

@thecodrr thecodrr Aug 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It indeed is. 😂😂

@thymikee thymikee merged commit 85c11b2 into react-native-community:fix/windows Aug 4, 2019
@thecodrr thecodrr deleted the fix-tests-on-windows branch August 4, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thymikee thymikee thymikee approved these changes

@Esemesek Esemesek Awaiting requested review from Esemesek

@grabbou grabbou Awaiting requested review from grabbou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thecodrr @thymikee