feat: Add prefers-color-scheme dark mode #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaitoAnderson
requested review from
Esemesek,
grabbou and
thymikee
as code owners
Member
|
Um, but this removes the dark mode for folks that are on light theme and still want to use dark in the debugger. Not mentioning Windows or various Linux distros that may not have this functionality. Can you bring the button down and set the default base on that CSS query? |
Contributor
Author
|
@thymikee Fair enough, I've changed it to just default to the user's system color scheme the first time it's opened. I did test Windows 10 as it does have a dark mode, works there too using Chrome 76. I haven't used Linux in years so I don't know if the popular distros are shipping a dark mode or not. Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Automatically set the appearance based on the global system dark mode, and remove the manual Dark Theme toggle.
Test Plan:
Set macOS Appearance to Light and Dark in System Preferences -> General and watch the debugging UI background change from white to black. Tested myself in Chrome 76 and Safari 12.1.2 on macOS 10.14.6.