fix: change how relative path to podfile is created #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation made assumption that path to podspec contains path to project root, which is not always the case, for example in monorepos. This caused incorrect generation of podspec path, since in that case it would return absolute podspec path prepended with root path. Used `pathname` class method `relative_path_from` to avoid this issue. Resolves #537
Contributor
|
We'll get this checked out on RNFB and let you know.. Ta! |
grabbou
approved these changes
Aug 7, 2019
Member
grabbou
left a comment
grabbou
left a comment
There was a problem hiding this comment.
This looks much better now (except for my limited Ruby knowledge).
thymikee
approved these changes
Aug 8, 2019
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Tested with 3 different scenarios and it seems to work just fine, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previous implementation made assumption that path to podspec contains
path to project root, which is not always the case, for example in
monorepos. This caused incorrect generation of podspec path, since in
that case it would return absolute podspec path prepended with root path.
Used
pathnameclass methodrelative_path_fromto avoid this issue.Resolves #537
Test Plan:
Tested manually in freshly initialised project and on an example mentioned by @sm1th here. This is still a WIP and I want to test it in other repos to make sure it works as expected.