Skip to content

fix: Infinite spinner when installing cocoapods #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2019
Merged

fix: Infinite spinner when installing cocoapods #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"semver": "^5.0.3",
"serve-static": "^1.13.1",
"shell-quote": "1.6.1",
"sudo-prompt": "^9.0.0",
"ws": "^1.1.0"
},
"peerDependencies": {
Expand Down
20 changes: 14 additions & 6 deletions packages/cli/src/tools/installPods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import Ora from 'ora';
import inquirer from 'inquirer';
import {logger} from '@react-native-community/cli-tools';
import {NoopLoader} from './loader';
import sudo from 'sudo-prompt';

async function updatePods(loader: typeof Ora) {
try {
Expand All @@ -28,6 +29,18 @@ async function updatePods(loader: typeof Ora) {
}
}

function runSudo(command: string): Promise<void> {
return new Promise((resolve, reject) => {
sudo.exec(command, error => {
if (error) {
reject(error);
}

resolve();
});
});
}

async function installPods({
projectName,
loader,
Expand Down Expand Up @@ -82,12 +95,7 @@ async function installPods({
} catch (_error) {
try {
// If that doesn't work then try with sudo
await execa('sudo', [
'gem',
'install',
'cocoapods',
'--no-document',
]);
await runSudo('gem install cocoapods --no-document');
} catch (error) {
loader.fail();
logger.log(error.stderr);
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8585,6 +8585,11 @@ strong-log-transformer@^2.0.0:
minimist "^1.2.0"
through "^2.3.4"

sudo-prompt@^9.0.0:
version "9.0.0"
resolved "https://registry.yarnpkg.com/sudo-prompt/-/sudo-prompt-9.0.0.tgz#eebedeee9fcd6f661324e6bb46335e3288e8dc8a"
integrity sha512-kUn5fiOk0nhY2oKD9onIkcNCE4Zt85WTsvOfSmqCplmlEvXCcPOmp1npH5YWuf8Bmyy9wLWkIxx+D+8cThBORQ==

supports-color@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-2.0.0.tgz#535d045ce6b6363fa40117084629995e9df324c7"
Expand Down