Skip to content

[Doctor] Export default functions directly #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2019
Merged

[Doctor] Export default functions directly #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/cli/src/commands/doctor/healthchecks/androidHomeEnvVariable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const URLS = {

const label = 'ANDROID_HOME';

const iosDeploy = {
export default {
label,
getDiagnostics: () => ({
needsToBeFixed: !process.env.ANDROID_HOME,
Expand All @@ -25,5 +25,3 @@ const iosDeploy = {
});
},
};

export default iosDeploy;
4 changes: 1 addition & 3 deletions packages/cli/src/commands/doctor/healthchecks/androidNDK.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {logManualInstallation} from './common';
import versionRanges from '../versionRanges';
import {doesSoftwareNeedToBeFixed} from '../checkInstallation';

const iosDeploy = {
export default {
label: 'Android NDK',
getDiagnosticsAsync: async ({SDKs}) => ({
needsToBeFixed: doesSoftwareNeedToBeFixed({
Expand Down Expand Up @@ -31,5 +31,3 @@ const iosDeploy = {
});
},
};

export default iosDeploy;
4 changes: 1 addition & 3 deletions packages/cli/src/commands/doctor/healthchecks/androidSDK.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {logManualInstallation} from './common';
import versionRanges from '../versionRanges';
import {doesSoftwareNeedToBeFixed} from '../checkInstallation';

const iosDeploy = {
export default {
label: 'Android SDK',
getDiagnosticsAsync: async ({SDKs}) => ({
needsToBeFixed: doesSoftwareNeedToBeFixed({
Expand Down Expand Up @@ -31,5 +31,3 @@ const iosDeploy = {
});
},
};

export default iosDeploy;
4 changes: 1 addition & 3 deletions packages/cli/src/commands/doctor/healthchecks/cocoaPods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const reportLoader = async ({loader, type, userHasSudoGranted}) => {
loader[type]();
};

const cocoaPods = {
export default {
label: 'CocoaPods',
getDiagnosticsAsync: async () => ({
needsToBeFixed: !(await isSoftwareInstalled('pod')),
Expand Down Expand Up @@ -50,5 +50,3 @@ const cocoaPods = {
}
},
};

export default cocoaPods;
4 changes: 1 addition & 3 deletions packages/cli/src/commands/doctor/healthchecks/iosDeploy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const getInstallationCommand = () => {
return undefined;
};

const iosDeploy = {
export default {
label: 'ios-deploy',
isRequired: false,
getDiagnosticsAsync: async () => ({
Expand Down Expand Up @@ -52,5 +52,3 @@ const iosDeploy = {
}
},
};

export default iosDeploy;
4 changes: 1 addition & 3 deletions packages/cli/src/commands/doctor/healthchecks/nodeJS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import versionRanges from '../versionRanges';
import {doesSoftwareNeedToBeFixed} from '../checkInstallation';
import {logManualInstallation} from './common';

const issue = {
export default {
label: 'Node.js',
getDiagnostics: ({Binaries}) => ({
version: Binaries.Node.version,
Expand All @@ -20,5 +20,3 @@ const issue = {
});
},
};

export default issue;
4 changes: 1 addition & 3 deletions packages/cli/src/commands/doctor/healthchecks/watchman.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import versionRanges from '../versionRanges';
import {doesSoftwareNeedToBeFixed} from '../checkInstallation';

const watchman = {
export default {
label: 'Watchman',
getDiagnostics: ({Binaries}) => ({
needsToBeFixed: doesSoftwareNeedToBeFixed({
Expand All @@ -11,5 +11,3 @@ const watchman = {
}),
runAutomaticFix: () => console.log('should fix watchman'),
};

export default watchman;
4 changes: 1 addition & 3 deletions packages/cli/src/commands/doctor/healthchecks/xcode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import versionRanges from '../versionRanges';
import {doesSoftwareNeedToBeFixed} from '../checkInstallation';
import {logManualInstallation} from './common';

const xcode = {
export default {
label: 'Xcode',
getDiagnostics: ({IDEs}) => ({
needsToBeFixed: doesSoftwareNeedToBeFixed({
Expand All @@ -19,5 +19,3 @@ const xcode = {
});
},
};

export default xcode;
6 changes: 2 additions & 4 deletions packages/cli/src/commands/doctor/printFixOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,12 @@ const printOptions = () => {
printOption(`${chalk.dim('Press')} Enter ${chalk.dim('to exit.')}`);
};

const printFixOptions = ({onKeyPress}) => {
export {KEYS};
export default ({onKeyPress}) => {
printOptions();

process.stdin.setRawMode(true);
process.stdin.resume();
process.stdin.setEncoding('utf8');
process.stdin.on('data', onKeyPress);
};

export {KEYS};
export default printFixOptions;
6 changes: 2 additions & 4 deletions packages/cli/src/commands/doctor/runAutomaticFix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ const AUTOMATIC_FIX_LEVELS = {
WARNINGS: 'WARNINGS',
};

const runAutomaticFix = async ({
export {AUTOMATIC_FIX_LEVELS};
export default async ({
healthchecks,
automaticFixLevel,
stats,
Expand Down Expand Up @@ -77,6 +78,3 @@ const runAutomaticFix = async ({
}
}
};

export {AUTOMATIC_FIX_LEVELS};
export default runAutomaticFix;